[SPARK-48623][CORE] Structured Logging Migrations#46980
Closed
asl3 wants to merge 19 commits into
Closed
Conversation
github-actions
Bot
added
SQL
ML
STRUCTURED STREAMING
BUILD
YARN
CORE
PYTHON
DSTREAM
CONNECT
labels
asl3
changed the title
| logError(s"Failed to delete temporary checksum file " + | ||
| s"at ${checksumTmp.getAbsolutePath}") | ||
| logError(log"Failed to delete temporary checksum file at " + | ||
| log"${MDC(LogKeys.FILE_ABSOLUTE_PATH, checksumTmp.getAbsolutePath)}") |
Contributor
Author
There was a problem hiding this comment.
I see LogKey.scala has this key which is used in other files: case object FILE_ABSOLUTE_PATH extends LogKey
should we migrate these other occurrences to PATH ? @gengliangwang
gengliangwang
approved these changes
Jun 17, 2024
Member
|
Thanks, merging to master |
gengliangwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR migrates Scala logging to comply with the scala style changes in #46979
Why are the changes needed?
This makes development and PR review of the structured logging migration easier.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested by ensuring
dev/scalastylechecks passWas this patch authored or co-authored using generative AI tooling?
No