Skip to content

[SPARK-48623][CORE] Structured logging migrations [Part 2]#47256

Closed
asl3 wants to merge 8 commits into
apache:masterfrom
asl3:morestructuredloggingmigrations
Closed

[SPARK-48623][CORE] Structured logging migrations [Part 2]#47256
asl3 wants to merge 8 commits into
apache:masterfrom
asl3:morestructuredloggingmigrations

Conversation

@asl3

@asl3 asl3 commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR makes additional Scala logging migrations to comply with the scala style changes in #46947

Why are the changes needed?

This makes development and PR review of the structured logging migration easier.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Tested by ensuring dev/scalastyle checks pass

Was this patch authored or co-authored using generative AI tooling?

No

@asl3

asl3 commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

cc @gengliangwang

Comment thread common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala
@github-actions github-actions Bot added the BUILD label Jul 8, 2024
Comment thread core/src/main/scala/org/apache/spark/SparkEnv.scala Outdated
Comment thread core/src/main/scala/org/apache/spark/util/ShutdownHookManager.scala Outdated
Comment thread dev/structured-logging-style.py Outdated
Comment thread streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala Outdated
Comment thread streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala Outdated
Comment thread streaming/src/main/scala/org/apache/spark/streaming/receiver/BlockGenerator.scala Outdated
@github-actions github-actions Bot removed the BUILD label Jul 8, 2024
@asl3 asl3 force-pushed the morestructuredloggingmigrations branch from 05fd230 to 121fd6c Compare July 8, 2024 22:25
@gengliangwang

Copy link
Copy Markdown
Member

Thanks, merging to master

jingz-db pushed a commit to jingz-db/spark that referenced this pull request Jul 22, 2024
### What changes were proposed in this pull request?
This PR makes additional Scala logging migrations to comply with the scala style changes in apache#46947

### Why are the changes needed?
This makes development and PR review of the structured logging migration easier.

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
Tested by ensuring dev/scalastyle checks pass

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#47256 from asl3/morestructuredloggingmigrations.

Authored-by: Amanda Liu <amanda.liu@databricks.com>
Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants