Skip to content

[SPARK-48941][PYTHON][ML] Replace RDD read / write API invocation with Dataframe read / write API #47411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WeichenXu123 wants to merge 4 commits into from
Closed

[SPARK-48941][PYTHON][ML] Replace RDD read / write API invocation with Dataframe read / write API #47411

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c41421c
init
WeichenXu123 Jul 19, 2024
ada650c
format
WeichenXu123 Jul 19, 2024
6e3be05
coalesce
WeichenXu123 Jul 19, 2024
22e5c7b
format
WeichenXu123 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python/pyspark/ml/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,10 @@ def saveMetadata(
metadataJson = DefaultParamsWriter._get_metadata_to_save(
instance, sc, extraMetadata, paramMap
)
sc.parallelize([metadataJson], 1).saveAsTextFile(metadataPath)
spark = SparkSession.getActiveSession()
spark.createDataFrame( # type: ignore[union-attr]
[(metadataJson,)], schema=["value"]
).coalesce(1).write.text(metadataPath)

@staticmethod
def _get_metadata_to_save(
Expand Down Expand Up @@ -577,7 +580,8 @@ def loadMetadata(path: str, sc: "SparkContext", expectedClassName: str = "") ->
If non empty, this is checked against the loaded metadata.
"""
metadataPath = os.path.join(path, "metadata")
metadataStr = sc.textFile(metadataPath, 1).first()
spark = SparkSession.getActiveSession()
metadataStr = spark.read.text(metadataPath).first()[0] # type: ignore[union-attr,index]
loadedVals = DefaultParamsReader._parseMetaData(metadataStr, expectedClassName)
return loadedVals

Expand Down