[SPARK-48961][PYTHON] Make the parameter naming of PySparkException consistent with JVM#47436
Closed
itholic wants to merge 5 commits into
Closed
[SPARK-48961][PYTHON] Make the parameter naming of PySparkException consistent with JVM#47436itholic wants to merge 5 commits into
PySparkException consistent with JVM#47436itholic wants to merge 5 commits into
Conversation
…onsistent with JVM
github-actions
Bot
added
SQL
STRUCTURED STREAMING
DOCS
CORE
PYTHON
AVRO
PANDAS API ON SPARK
CONNECT
labels
Contributor
Author
|
cc @HyukjinKwon |
HyukjinKwon
reviewed
Jul 22, 2024
Contributor
Author
|
Merged into master. Thanks! |
ilicmarkodb
pushed a commit
to ilicmarkodb/spark
that referenced
this pull request
Jul 29, 2024
… consistent with JVM ### What changes were proposed in this pull request? This PR proposes to make the parameter naming of `PySparkException` consistent with JVM ### Why are the changes needed? The parameter names of `PySparkException` are different from `SparkException` so there is an inconsistency when searching those parameters from error logs. SparkException: https://github.com/apache/spark/blob/6508b1f5e18731359354af0a7bcc1382bc4f356b/common/utils/src/main/scala/org/apache/spark/SparkException.scala#L27-L33 PySparkException: https://github.com/apache/spark/blob/6508b1f5e18731359354af0a7bcc1382bc4f356b/python/pyspark/errors/exceptions/base.py#L29-L40 ### Does this PR introduce _any_ user-facing change? The error parameter names are changed from: - `error_class` -> `errorClass` - `message_parameters` -> `messageParameters` - `query_contexts` -> `context` ### How was this patch tested? The existing CI should pass ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47436 from itholic/SPARK-48961. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Haejoon Lee <haejoon.lee@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make the parameter naming of
PySparkExceptionconsistent with JVMWhy are the changes needed?
The parameter names of
PySparkExceptionare different fromSparkExceptionso there is an inconsistency when searching those parameters from error logs.SparkException:
spark/common/utils/src/main/scala/org/apache/spark/SparkException.scala
Lines 27 to 33 in 6508b1f
PySparkException:
spark/python/pyspark/errors/exceptions/base.py
Lines 29 to 40 in 6508b1f
Does this PR introduce any user-facing change?
The error parameter names are changed from:
error_class->errorClassmessage_parameters->messageParametersquery_contexts->contextHow was this patch tested?
The existing CI should pass
Was this patch authored or co-authored using generative AI tooling?
No.