Skip to content

[SPARK-49053][PYTHON][ML] Make model save/load helper functions accept spark session#47527

Closed
zhengruifeng wants to merge 1 commit into
apache:masterfrom
zhengruifeng:py_ml_save_metadata_spark
Closed

[SPARK-49053][PYTHON][ML] Make model save/load helper functions accept spark session#47527
zhengruifeng wants to merge 1 commit into
apache:masterfrom
zhengruifeng:py_ml_save_metadata_spark

Conversation

@zhengruifeng

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Make model save/load helper functions accept spark session

Why are the changes needed?

1, avoid unnecessary spark session creations;
2, to be consistent with scala side changes: #47467 and #47477

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI

Was this patch authored or co-authored using generative AI tooling?

No

fix lint
@zhengruifeng zhengruifeng force-pushed the py_ml_save_metadata_spark branch from fe18774 to ea1d713 Compare July 30, 2024 01:34

@WeichenXu123 WeichenXu123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon

Copy link
Copy Markdown
Member

Merged to master.

@zhengruifeng zhengruifeng deleted the py_ml_save_metadata_spark branch July 30, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants