[SPARK-49352][SQL][3.4] Avoid redundant array transform for identical expression#47862
Closed
viirya wants to merge 1 commit into
Closed
[SPARK-49352][SQL][3.4] Avoid redundant array transform for identical expression#47862viirya wants to merge 1 commit into
viirya wants to merge 1 commit into
Conversation
viirya
changed the title
Member
Author
dongjoon-hyun
approved these changes
Aug 24, 2024
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM (Pending CIs). Thank you, @viirya .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 24, 2024
… expression ### What changes were proposed in this pull request? This patch avoids `ArrayTransform` in `resolveArrayType` function if the resolution expression is the same as input param. ### Why are the changes needed? Our customer encounters significant performance regression when migrating from Spark 3.2 to Spark 3.4 on a `Insert Into` query which is analyzed as a `AppendData` on an Iceberg table. We found that the root cause is in Spark 3.4, `TableOutputResolver` resolves the query with additional `ArrayTransform` on an `ArrayType` field. The `ArrayTransform`'s lambda function is actually an identical function, i.e., the transformation is redundant. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test and manual e2e test ### Was this patch authored or co-authored using generative AI tooling? No Closes #47862 from viirya/fix_redundant_array_transform_3.4. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to branch-3.4. |
Member
Author
|
Thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch avoids
ArrayTransforminresolveArrayTypefunction if the resolution expression is the same as input param.Why are the changes needed?
Our customer encounters significant performance regression when migrating from Spark 3.2 to Spark 3.4 on a
Insert Intoquery which is analyzed as aAppendDataon an Iceberg table.We found that the root cause is in Spark 3.4,
TableOutputResolverresolves the query with additionalArrayTransformon anArrayTypefield. TheArrayTransform's lambda function is actually an identical function, i.e., the transformation is redundant.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test and manual e2e test
Was this patch authored or co-authored using generative AI tooling?
No