[SPARK-49443][SQL][FOLLOWUP] Fix formatting of a comment for to_variant_object()#48060
Closed
MaxGekk wants to merge 2 commits into
Closed
[SPARK-49443][SQL][FOLLOWUP] Fix formatting of a comment for to_variant_object()#48060MaxGekk wants to merge 2 commits into
to_variant_object()#48060MaxGekk wants to merge 2 commits into
Conversation
MaxGekk
changed the title
to_variant_object()to_variant_object()
dongjoon-hyun
requested changes
Sep 10, 2024
Member
There was a problem hiding this comment.
Hi, @MaxGekk .
As you see in this PR builder failure (https://github.com/MaxGekk/spark/actions/runs/10795608001/job/29942721994), the master branch is broken before this style issue. Could you fix the compilation first?
Member
Author
|
@dongjoon-hyun I am working on a fix now. |
Member
|
Thank you so much, @MaxGekk ! |
dongjoon-hyun
approved these changes
Sep 10, 2024
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk .
cloud-fan
approved these changes
Sep 10, 2024
Member
Author
|
The GA Run / Linters, licenses, and dependencies passed. Merging to master. Thank you, @dongjoon-hyun and @cloud-fan for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix formatting of comments for the function
to_variant_object().Why are the changes needed?
To fix the failure:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the formatting:
Was this patch authored or co-authored using generative AI tooling?
No.