[SPARK-49579][SQL][TESTS][FOLLOWUP] Use condition instead of errorClass in SparkThrowableSuite and in DateTimeFormatterHelperSuite#48061
Closed
MaxGekk wants to merge 1 commit into
Closed
Conversation
Member
|
Feel free to merge this if you verified locally, @MaxGekk . |
Member
Author
|
@dongjoon-hyun I have tested the changes locally, but let's wait for a few minutes till compilation in GAs is done. |
Member
Author
|
Merging to master. Thank you, @dongjoon-hyun for the quick review. |
Member
|
Thank you for quick follow-up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to use
conditioninstead oferrorClassin two test suites:Why are the changes needed?
Because the changes from the PR #48027 conflict to #48058 and #48026, and tests in #48027 were passed earlier than the last PRs were merged to master.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By compiling and running the following tests locally:
Was this patch authored or co-authored using generative AI tooling?
No.