Skip to content

[SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" and "TOK_SHOWINDEXES"#4907

Closed
pzzs wants to merge 4 commits into
apache:masterfrom
pzzs:delete_TOK_CREATEFUNCTION
Closed

[SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" and "TOK_SHOWINDEXES"#4907
pzzs wants to merge 4 commits into
apache:masterfrom
pzzs:delete_TOK_CREATEFUNCTION

Conversation

@pzzs

@pzzs pzzs commented Mar 5, 2015

Copy link
Copy Markdown
Contributor

Line 65 "TOK_SHOWINDEXES"
Line 66 "TOK_SHOWINDEXES"

Line 84 "TOK_CREATEFUNCTION"
Line 106 "TOK_CREATEFUNCTION"

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@chenghao-intel

Copy link
Copy Markdown
Contributor

ok to test

@chenghao-intel

Copy link
Copy Markdown
Contributor

Good catch, LGTM.

@adrian-wang

Copy link
Copy Markdown
Contributor

Maybe we can sort all these tokens in alphabetic order to avoid duplicate.

Line 65  TOK_SHOWINDEXES
Line 66  TOK_SHOWINDEXES
@pzzs pzzs changed the title [SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" has existed at Line 84 [SPARK-6185][SQL] Deltele repeated TOKEN. "TOK_CREATEFUNCTION" and "TOK_SHOWINDEXES" Mar 7, 2015
@pzzs

pzzs commented Mar 7, 2015

Copy link
Copy Markdown
Contributor Author

Anyone could test it? @chenghao-intel @marmbrus

@yhuai

yhuai commented Mar 9, 2015

Copy link
Copy Markdown
Contributor

ok to test

@SparkQA

SparkQA commented Mar 9, 2015

Copy link
Copy Markdown

Test build #28381 has started for PR 4907 at commit c0bd3f9.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 9, 2015

Copy link
Copy Markdown

Test build #28381 has finished for PR 4907 at commit c0bd3f9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28381/
Test PASSed.

@pzzs

pzzs commented Mar 11, 2015

Copy link
Copy Markdown
Contributor Author

@yhuai Could it be merged?

@adrian-wang

Copy link
Copy Markdown
Contributor

Again, I think we'd better sort these tokens in alphabetic order to avoid further duplicate

@marmbrus

Copy link
Copy Markdown
Contributor

+1 to sorting.
On Mar 10, 2015 7:26 PM, "Daoyuan Wang" notifications@github.com wrote:

Again, I think we'd better sort these tokens in alphabetic order to avoid
further duplicate


Reply to this email directly or view it on GitHub
#4907 (comment).

@pzzs

pzzs commented Mar 11, 2015

Copy link
Copy Markdown
Contributor Author

It is a good idea that to sorting , i will do it @adrian-wang @marmbrus @chenghao-intel

@pzzs

pzzs commented Mar 11, 2015

Copy link
Copy Markdown
Contributor Author

I hava opened a new pr for sorting these tokens in alphabetic.
#4973 @yhuai @marmbrus

@srowen

srowen commented Mar 11, 2015

Copy link
Copy Markdown
Member

Mind closing this PR?

@pzzs

pzzs commented Mar 12, 2015

Copy link
Copy Markdown
Contributor Author

yes i will close it @srowen

@pzzs pzzs closed this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants