[MINOR][CORE] Remove unused private[executor] var httpUrlConnectionTimeoutMillis from ExecutorClassLoader#50152
Closed
LuciferYang wants to merge 1 commit into
Closed
Conversation
dongjoon-hyun
approved these changes
Mar 4, 2025
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang .
Merged to master.
Contributor
Author
|
Thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to remove unused
private[executor] var httpUrlConnectionTimeoutMillisfromExecutorClassLoader.The definition of
httpUrlConnectionTimeoutMilliswas introduced in SPARK-6209 (#4944) and was used by the functiongetClassFileInputStreamFromHttpServer. After SPARK-23538(#20723), the functiongetClassFileInputStreamFromHttpServerwas removed fromExecutorClassLoader, andhttpUrlConnectionTimeoutMillisis no longer used either.Why are the changes needed?
Code cleanup
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Action
Was this patch authored or co-authored using generative AI tooling?
No