Skip to content

[SPARK-6054][SQL] Fix transformations of TreeNodes that hold StructTypes#5157

Closed
marmbrus wants to merge 1 commit into
apache:masterfrom
marmbrus:udfFix
Closed

[SPARK-6054][SQL] Fix transformations of TreeNodes that hold StructTypes#5157
marmbrus wants to merge 1 commit into
apache:masterfrom
marmbrus:udfFix

Conversation

@marmbrus

Copy link
Copy Markdown
Contributor

Due to a recent change that made StructType a Seq we started inadvertently turning StructTypes into generic Traversable when attempting nested tree transformations. In this PR we explicitly avoid descending into DataTypes to avoid this bug.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29060 has finished for PR 5157 at commit 26f7087.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai

yhuai commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

LGTM

asfgit pushed a commit that referenced this pull request Mar 24, 2015
Due to a recent change that made `StructType` a `Seq` we started inadvertently turning `StructType`s into generic `Traversable` when attempting nested tree transformations.  In this PR we explicitly avoid descending into `DataType`s to avoid this bug.

Author: Michael Armbrust <michael@databricks.com>

Closes #5157 from marmbrus/udfFix and squashes the following commits:

26f7087 [Michael Armbrust] Fix transformations of TreeNodes that hold StructTypes

(cherry picked from commit 3fa3d12)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 3fa3d12 Mar 24, 2015
@marmbrus marmbrus deleted the udfFix branch August 3, 2015 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants