Skip to content

[SPARK-6437][SQL] Use completion iterator to close external sorter#5161

Closed
marmbrus wants to merge 2 commits into
apache:masterfrom
marmbrus:cleanupAfterSort
Closed

[SPARK-6437][SQL] Use completion iterator to close external sorter#5161
marmbrus wants to merge 2 commits into
apache:masterfrom
marmbrus:cleanupAfterSort

Conversation

@marmbrus

Copy link
Copy Markdown
Contributor

Otherwise we will leak files when spilling occurs.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29067 has finished for PR 5161 at commit cdebdf5.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29070 has finished for PR 5161 at commit cb13d3c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai

yhuai commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

LGTM

asfgit pushed a commit that referenced this pull request Mar 24, 2015
Otherwise we will leak files when spilling occurs.

Author: Michael Armbrust <michael@databricks.com>

Closes #5161 from marmbrus/cleanupAfterSort and squashes the following commits:

cb13d3c [Michael Armbrust] hint to inferencer
cdebdf5 [Michael Armbrust] Use completion iterator to close external sorter

(cherry picked from commit 26c6ce3)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 26c6ce3 Mar 24, 2015
@marmbrus marmbrus deleted the cleanupAfterSort branch August 3, 2015 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants