Skip to content

[SPARK-6428][SQL] Added explicit types for all public methods in catalyst#5162

Closed
rxin wants to merge 1 commit into
apache:masterfrom
rxin:catalyst-explicit-types
Closed

[SPARK-6428][SQL] Added explicit types for all public methods in catalyst#5162
rxin wants to merge 1 commit into
apache:masterfrom
rxin:catalyst-explicit-types

Conversation

@rxin

@rxin rxin commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

I think after this PR, we can finally turn the rule on. There are still some smaller ones that need to be fixed, but those are easier.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29069 has started for PR 5162 at commit 4fa948e.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29069 has finished for PR 5162 at commit 4fa948e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • implicit class DslSymbol(sym: Symbol) extends ImplicitAttribute

@AmplabJenkins

AmplabJenkins commented Mar 24, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29069/
Test PASSed.

marmbrus
marmbrus reviewed Mar 24, 2015
View reviewed changes
Comment thread sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala

@marmbrus marmbrus Mar 24, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit

@rxin rxin Mar 24, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit won't actually compile because we use this as the last statement in transformExpressionUp and the compiler expects this function to return something.

@marmbrus marmbrus Mar 24, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, no this is correct...

@marmbrus

marmbrus commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

LGTM

@rxin rxin force-pushed the catalyst-explicit-types branch from 4fa948e to 33797be Compare March 24, 2015 20:25
@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29107 has started for PR 5162 at commit 33797be.

  • This patch does not merge cleanly.

@rxin rxin force-pushed the catalyst-explicit-types branch from 33797be to 5e1370f Compare March 24, 2015 20:28
@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29109 has started for PR 5162 at commit 5e1370f.

  • This patch merges cleanly.

@rxin rxin force-pushed the catalyst-explicit-types branch from 5e1370f to e7eac03 Compare March 24, 2015 21:36
@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29112 has started for PR 5162 at commit e7eac03.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29109 has finished for PR 5162 at commit 5e1370f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • implicit class DslSymbol(sym: Symbol) extends ImplicitAttribute
    • case class Alias(child: Expression, name: String)(
    • class Column(protected[sql] val expr: Expression) extends Logging

@AmplabJenkins

AmplabJenkins commented Mar 24, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29109/
Test PASSed.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29107 has finished for PR 5162 at commit 33797be.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • implicit class DslSymbol(sym: Symbol) extends ImplicitAttribute
    • case class Alias(child: Expression, name: String)(
    • class Column(protected[sql] val expr: Expression) extends Logging

@AmplabJenkins

AmplabJenkins commented Mar 24, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29107/
Test PASSed.

@SparkQA

SparkQA commented Mar 24, 2015

Copy link
Copy Markdown

Test build #29112 has finished for PR 5162 at commit e7eac03.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • implicit class DslSymbol(sym: Symbol) extends ImplicitAttribute

@AmplabJenkins

AmplabJenkins commented Mar 24, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29112/
Test PASSed.

@asfgit asfgit closed this in 7334801 Mar 24, 2015
asfgit pushed a commit that referenced this pull request Mar 24, 2015
@rxin
[SPARK-6428][SQL] Added explicit types for all public methods in cata…
586e0d9 
…lyst

I think after this PR, we can finally turn the rule on. There are still some smaller ones that need to be fixed, but those are easier.

Author: Reynold Xin <rxin@databricks.com>

Closes #5162 from rxin/catalyst-explicit-types and squashes the following commits:

e7eac03 [Reynold Xin] [SPARK-6428][SQL] Added explicit types for all public methods in catalyst.

(cherry picked from commit 7334801)
Signed-off-by: Reynold Xin <rxin@databricks.com>

Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin @SparkQA @AmplabJenkins @marmbrus