[SPARK-6555] [SQL] Overrides equals() and hashCode() for MetastoreRelation#5289
[SPARK-6555] [SQL] Overrides equals() and hashCode() for MetastoreRelation#5289liancheng wants to merge 3 commits into
Conversation
|
Test build #29472 has started for PR 5289 at commit |
There was a problem hiding this comment.
Actually the trouble maker is PlanTest.comparePlans, because now MetastoreRelation also compares output attributes. But right now I don't have a clean solution for this. Thus, I replace the original metastore relation with a temporary relation to pass the test here.
There was a problem hiding this comment.
I think thats actually reasonable. Compare plans is mostly about checking plan structure.
There was a problem hiding this comment.
I'd even be okay adding a special rule to compare plans that always replaces MetastoreRelations with LocalRelation
|
Test build #29474 has started for PR 5289 at commit |
|
Test build #29472 has finished for PR 5289 at commit
|
|
Test PASSed. |
|
Test build #29474 has finished for PR 5289 at commit
|
|
Test PASSed. |
There was a problem hiding this comment.
All changes above this line are about reverting workaround introduced in #5183.
…ation Also removes temporary workarounds made in #5183 and #5251. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/5289) <!-- Reviewable:end --> Author: Cheng Lian <lian@databricks.com> Closes #5289 from liancheng/spark-6555 and squashes the following commits: d0095ac [Cheng Lian] Removes unused imports cfafeeb [Cheng Lian] Removes outdated comment 75a2746 [Cheng Lian] Overrides equals() and hashCode() for MetastoreRelation (cherry picked from commit a7992ff) Signed-off-by: Michael Armbrust <michael@databricks.com>
|
Thanks! Merged to master and 1.3 |
Also removes temporary workarounds made in #5183 and #5251.