Skip to content

[SPARK-56920][SQL][FOLLOWUP] Format METRIC_VIEW DESCRIBE output distinctly from VIEW #55983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 1 commit into from
Closed

[SPARK-56920][SQL][FOLLOWUP] Format METRIC_VIEW DESCRIBE output distinctly from VIEW #55983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ case class CatalogTable(
if (comment.isDefined) map += "Comment" -> JString(comment.get)
if (collation.isDefined) map += "Collation" -> JString(collation.get)

if (isViewLike) {
if (tableType == CatalogTableType.VIEW) {
if (viewText.isDefined) {
map += "View Text" -> JString(viewText.get)
}
Expand Down Expand Up @@ -710,6 +710,15 @@ case class CatalogTable(
if (viewQueryOutputColumns != JNull) {
map += "View Query Output Columns" -> viewQueryOutputColumns
}
} else if (tableType == CatalogTableType.METRIC_VIEW) {
// METRIC_VIEW stores a YAML body in `viewText`, not a SQL query. The schema-binding
// fields used by plain VIEW (View Schema Mode, View Catalog and Namespace, SQL Path,
// View Query Output Columns) do not apply, so emit only `View Text` plus a `Language`
// tag so consumers can dispatch on the view_text format.
if (viewText.isDefined) {
map += "View Text" -> JString(viewText.get)
}
map += "Language" -> JString("YAML")
}
if (tableProperties != JNull) map += "Table Properties" -> tableProperties
stats.foreach { s =>
Expand Down