Skip to content

[SPARK-57689][BUILD] Replace kubernetes-httpclient-okhttp with kubernetes-httpclient-vertx in LICENSE-binary#56765

Closed
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-57689
Closed

[SPARK-57689][BUILD] Replace kubernetes-httpclient-okhttp with kubernetes-httpclient-vertx in LICENSE-binary#56765
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-57689

Conversation

@dongjoon-hyun

@dongjoon-hyun dongjoon-hyun commented Jun 25, 2026

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR updates LICENSE-binary to replace io.fabric8:kubernetes-httpclient-okhttp
with io.fabric8:kubernetes-httpclient-vertx:

-io.fabric8:kubernetes-httpclient-okhttp
+io.fabric8:kubernetes-httpclient-vertx

Why are the changes needed?

After the fabric8 kubernetes-client 7.x upgrade (SPARK-50493) switched the HTTP
backend from OkHttp to Vert.x, the distribution bundles kubernetes-httpclient-vertx
instead of kubernetes-httpclient-okhttp. This keeps LICENSE-binary consistent
with the actual bundled jars. Both are Apache License 2.0.

kubernetes-httpclient-vertx/7.7.0//kubernetes-httpclient-vertx-7.7.0.jar

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

cc @huaxingao as the release manager.

…ernetes-httpclient-vertx` in `LICENSE-binary`

@huaxingao huaxingao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Thank you, @huaxingao !

dongjoon-hyun added a commit that referenced this pull request Jun 25, 2026
…ernetes-httpclient-vertx` in `LICENSE-binary`

### What changes were proposed in this pull request?

This PR updates `LICENSE-binary` to replace `io.fabric8:kubernetes-httpclient-okhttp`
with `io.fabric8:kubernetes-httpclient-vertx`:

```
-io.fabric8:kubernetes-httpclient-okhttp
+io.fabric8:kubernetes-httpclient-vertx
```

### Why are the changes needed?

After the fabric8 `kubernetes-client` 7.x upgrade (SPARK-50493) switched the HTTP
backend from OkHttp to Vert.x, the distribution bundles `kubernetes-httpclient-vertx`
instead of `kubernetes-httpclient-okhttp`. This keeps `LICENSE-binary` consistent
with the actual bundled jars. Both are Apache License 2.0.

- #49159

https://github.com/apache/spark/blob/e6fcb8440915e6e0f4f4945b486bfb2c568f9562/dev/deps/spark-deps-hadoop-3-hive-2.3#L160

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

Closes #56765 from dongjoon-hyun/SPARK-57689.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 5d2a111)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Jun 25, 2026
…ernetes-httpclient-vertx` in `LICENSE-binary`

### What changes were proposed in this pull request?

This PR updates `LICENSE-binary` to replace `io.fabric8:kubernetes-httpclient-okhttp`
with `io.fabric8:kubernetes-httpclient-vertx`:

```
-io.fabric8:kubernetes-httpclient-okhttp
+io.fabric8:kubernetes-httpclient-vertx
```

### Why are the changes needed?

After the fabric8 `kubernetes-client` 7.x upgrade (SPARK-50493) switched the HTTP
backend from OkHttp to Vert.x, the distribution bundles `kubernetes-httpclient-vertx`
instead of `kubernetes-httpclient-okhttp`. This keeps `LICENSE-binary` consistent
with the actual bundled jars. Both are Apache License 2.0.

- #49159

https://github.com/apache/spark/blob/e6fcb8440915e6e0f4f4945b486bfb2c568f9562/dev/deps/spark-deps-hadoop-3-hive-2.3#L160

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

Closes #56765 from dongjoon-hyun/SPARK-57689.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 5d2a111)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Jun 25, 2026
…ernetes-httpclient-vertx` in `LICENSE-binary`

### What changes were proposed in this pull request?

This PR updates `LICENSE-binary` to replace `io.fabric8:kubernetes-httpclient-okhttp`
with `io.fabric8:kubernetes-httpclient-vertx`:

```
-io.fabric8:kubernetes-httpclient-okhttp
+io.fabric8:kubernetes-httpclient-vertx
```

### Why are the changes needed?

After the fabric8 `kubernetes-client` 7.x upgrade (SPARK-50493) switched the HTTP
backend from OkHttp to Vert.x, the distribution bundles `kubernetes-httpclient-vertx`
instead of `kubernetes-httpclient-okhttp`. This keeps `LICENSE-binary` consistent
with the actual bundled jars. Both are Apache License 2.0.

- #49159

https://github.com/apache/spark/blob/e6fcb8440915e6e0f4f4945b486bfb2c568f9562/dev/deps/spark-deps-hadoop-3-hive-2.3#L160

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

Closes #56765 from dongjoon-hyun/SPARK-57689.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 5d2a111)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request Jun 25, 2026
…ernetes-httpclient-vertx` in `LICENSE-binary`

### What changes were proposed in this pull request?

This PR updates `LICENSE-binary` to replace `io.fabric8:kubernetes-httpclient-okhttp`
with `io.fabric8:kubernetes-httpclient-vertx`:

```
-io.fabric8:kubernetes-httpclient-okhttp
+io.fabric8:kubernetes-httpclient-vertx
```

### Why are the changes needed?

After the fabric8 `kubernetes-client` 7.x upgrade (SPARK-50493) switched the HTTP
backend from OkHttp to Vert.x, the distribution bundles `kubernetes-httpclient-vertx`
instead of `kubernetes-httpclient-okhttp`. This keeps `LICENSE-binary` consistent
with the actual bundled jars. Both are Apache License 2.0.

- #49159

https://github.com/apache/spark/blob/e6fcb8440915e6e0f4f4945b486bfb2c568f9562/dev/deps/spark-deps-hadoop-3-hive-2.3#L160

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

Closes #56765 from dongjoon-hyun/SPARK-57689.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 5d2a111)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Merged to master/4.x/4.2/4.1/4.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-57689 branch June 25, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants