Skip to content

[SPARK-7153][SQL] support all integral type ordinal in GetArrayItem#5706

Closed
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:7153
Closed

[SPARK-7153][SQL] support all integral type ordinal in GetArrayItem#5706
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:7153

Conversation

@cloud-fan

@cloud-fan cloud-fan commented Apr 26, 2015

Copy link
Copy Markdown
Contributor

first convert ordinal to Number, then convert to int type.

@cloud-fan

cloud-fan commented Apr 26, 2015

Copy link
Copy Markdown
Contributor Author

Jenkins test it please.

@cloud-fan

cloud-fan commented Apr 27, 2015

Copy link
Copy Markdown
Contributor Author

Hi @rxin , how can I trigger the jenkins to run test?

@rxin

rxin commented Apr 27, 2015

Copy link
Copy Markdown
Contributor

Jenkins, test this please.

@rxin

rxin commented Apr 27, 2015

Copy link
Copy Markdown
Contributor

(I think you need permission from us to do it)

@AmplabJenkins

AmplabJenkins commented Apr 27, 2015

Copy link
Copy Markdown

Can one of the admins verify this patch?

@cloud-fan

cloud-fan commented Apr 28, 2015

Copy link
Copy Markdown
Contributor Author

Seems Jenkins got a problem...

@cloud-fan cloud-fan changed the title [SPARK-7153][SQL] support long type ordinal in GetItem [SPARK-7153][SQL] support long type ordinal in GetArrayItem May 12, 2015
@cloud-fan

cloud-fan commented May 12, 2015

Copy link
Copy Markdown
Contributor Author

test this please.

@cloud-fan cloud-fan changed the title [SPARK-7153][SQL] support long type ordinal in GetArrayItem [SPARK-7153][SQL] support all integral type ordinal in GetArrayItem Jun 19, 2015
@cloud-fan

cloud-fan commented Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

As we have moved out all ExtractValue(GetField) stuff from complexType.scala, we should rename it.

@cloud-fan

cloud-fan commented Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

cc @marmbrus , it's a minor change.

@marmbrus

marmbrus commented Jun 19, 2015

Copy link
Copy Markdown
Contributor

ok to test

@AmplabJenkins

AmplabJenkins commented Jun 19, 2015

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jun 19, 2015

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Jun 19, 2015

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

AmplabJenkins commented Jun 21, 2015

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jun 21, 2015

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented Jun 21, 2015

Copy link
Copy Markdown

Test build #35384 has started for PR 5706 at commit 915db79.

@SparkQA

SparkQA commented Jun 21, 2015

Copy link
Copy Markdown

Test build #35384 has finished for PR 5706 at commit 915db79.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented Jun 21, 2015

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@cloud-fan

cloud-fan commented Jun 21, 2015

Copy link
Copy Markdown
Contributor Author

retest this please.

@AmplabJenkins

AmplabJenkins commented Jun 21, 2015

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jun 21, 2015

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented Jun 21, 2015

Copy link
Copy Markdown

Test build #35393 has started for PR 5706 at commit 915db79.

@SparkQA

SparkQA commented Jun 21, 2015

Copy link
Copy Markdown

Test build #35393 has finished for PR 5706 at commit 915db79.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented Jun 21, 2015

Copy link
Copy Markdown

Merged build finished. Test PASSed.

@marmbrus

marmbrus commented Jun 23, 2015

Copy link
Copy Markdown
Contributor

Thanks! Merging to master.

@asfgit asfgit closed this in 860a49e Jun 23, 2015
animeshbaranawal pushed a commit to animeshbaranawal/spark that referenced this pull request Jun 25, 2015
@cloud-fan
[SPARK-7153] [SQL] support all integral type ordinal in GetArrayItem
29fc90e 
first convert `ordinal` to `Number`, then convert to int type.

Author: Wenchen Fan <cloud0fan@outlook.com>

Closes apache#5706 from cloud-fan/7153 and squashes the following commits:

915db79 [Wenchen Fan] fix 7153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cloud-fan @rxin @AmplabJenkins @marmbrus @SparkQA