[SPARK-58209][SQL] Mark stateful expressions to prevent data races#57371
Draft
huanghanyu-vungle wants to merge 4 commits into
Draft
[SPARK-58209][SQL] Mark stateful expressions to prevent data races#57371huanghanyu-vungle wants to merge 4 commits into
huanghanyu-vungle wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR marks
XPathExtract,CallMethodViaReflection, andUserDefinedGeneratoras stateful Catalyst expressions.It also adds focused regression tests verifying that
freshCopyIfContainsStatefulExpression()returns a distinct expression instance while preservingthe expression's children and configuration.
Why are the changes needed?
These expressions retain mutable runtime state, including an XPath evaluator, a reusable
reflection argument buffer, and generator projections/converters. They currently inherit
stateful = false, so independent query executions can reuse the same expression instance.Concurrent executor tasks may then race on the shared state and silently produce incorrect
results.
Declaring the expressions stateful makes Catalyst create a fresh, uninitialized expression for
each execution path using its existing fresh-copy mechanism.
Does this PR introduce any user-facing change?
Yes. Concurrent query executions no longer risk incorrect results caused by shared mutable state
in these expressions. There is no SQL API or syntax change.
How was this patch tested?
Added fresh-copy regression coverage to
XPathExpressionSuite,CallMethodViaReflectionSuite, andGeneratorExpressionSuite.The three suites passed 27 tests, and Catalyst Scalastyle processed 705 files with no findings.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)