[SPARK-58228][SQL] Convert unreachable error condition _LEGACY_ERROR_TEMP_1058 to an internal error#57384
Open
Ma77Ball wants to merge 1 commit into
Open
[SPARK-58228][SQL] Convert unreachable error condition _LEGACY_ERROR_TEMP_1058 to an internal error#57384Ma77Ball wants to merge 1 commit into
Ma77Ball wants to merge 1 commit into
Conversation
…TEMP_1058 to an internal error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Convert
_LEGACY_ERROR_TEMP_1058(raised inResolveSessionCatalogwhen a table has bothUSINGand a Hive SerDe) into aSparkException.internalError, and remove the condition fromerror-conditions.jsonplus its now-unusedQueryCompilationErrorshelper.Part of SPARK-37935.
Why are the changes needed?
This branch is unreachable by users: the parser rejects
USING+STORED AS/ROW FORMATbefore analysis, and no DataFrame/Catalog API sets SerDe info. It can only fire if an invalid plan is built internally, so it is a bug guard, not a user error. Naming it as a user-facing condition would misclassify it;internalErroris the correct classification.Does this PR introduce any user-facing change?
No.
How was this patch tested?
No new test (the path is unreachable from SQL). Existing
DDLParserSuite(parser rejection) andSparkThrowableSuite(error-catalog consistency) pass.Was this patch authored or co-authored using generative AI tooling?
Discovered-with: Claude Opus 4.8