[SPARK-58231][GRAPHX][FOLLOW UP] Add regression test for SVD++ aggregateMessages combiner#57392
Open
Ma77Ball wants to merge 1 commit into
Open
Conversation
Ma77Ball
changed the title
Contributor
Author
|
cc @Yicong-Huang and @uros-b PTAL when you are available. I added the regression test discussed in PR #57314 to cover SVD++. |
uros-b
approved these changes
Jul 21, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
Thank you @Ma77Ball! PTAL too @Yicong-Huang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to SPARK-58177 / #57314, which fixed a wrong operand in the SVD++ Phase 2
aggregateMessagescombiner but merged without a test. This adds the regression test:SVDPlusPlus.combineTrainMessages, and use it in place of the inlineaggregateMessagescombiner.SVDPlusPlusSuitethat asserts both vectors and the scalar are summed element-wise, and that the input messages are not mutated.Why are the changes needed?
The fixed bug (the second vector was based on
g2._2, which droppedg1._2and doubledg2._2) only manifests when a vertex merges two or more differing messages, and the combiner was an inline lambda that could not be tested directly. Extracting it makes the merge logic unit-testable and guards against a future regression.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added a unit test in
SVDPlusPlusSuite; the full suite passes locally. The test was confirmed to fail when the pre-fix operand (g2._2) is restored and to pass with the fix in place.Was this patch authored or co-authored using generative AI tooling?
No