[SPARK-58158][CORE][UI][4.1][FOLLOWUP] Fix broken jQuery import path in executorspage.test.js#57393
Closed
LuciferYang wants to merge 1 commit into
Closed
[SPARK-58158][CORE][UI][4.1][FOLLOWUP] Fix broken jQuery import path in executorspage.test.js#57393LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
…in executorspage.test.js The `executorspage.test.js` added by SPARK-58158 imports `jquery.min.js`, but that file only exists on `master`, where SPARK-54235 renamed `jquery-3.5.1.min.js` to the version-agnostic `jquery.min.js`. SPARK-54235 is a master-only jQuery upgrade and was not backported, so on `branch-4.1` the file is still named `jquery-3.5.1.min.js` and the import fails: ``` FAIL tests/executorspage.test.js Cannot find module '.../ui/static/jquery.min.js' from 'tests/executorspage.test.js' ``` This breaks the daily "Run Spark UI tests" job on `branch-4.1`. The other three ui-test files on this branch already import `jquery-3.5.1.min.js`; this aligns `executorspage.test.js` with them. The `jquery.dataTables.min.js` import on the next line is fine (that file exists on the branch). Generated-by: Claude Code (Opus 4.8)
LuciferYang
commented
Jul 21, 2026
| */ | ||
|
|
||
| import '../../core/src/main/resources/org/apache/spark/ui/static/jquery.min.js'; | ||
| import '../../core/src/main/resources/org/apache/spark/ui/static/jquery-3.5.1.min.js'; |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
also cc @HyukjinKwon |
HyukjinKwon
approved these changes
Jul 21, 2026
uros-b
approved these changes
Jul 21, 2026
dongjoon-hyun
approved these changes
Jul 21, 2026
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
Thank you, @LuciferYang and all.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 21, 2026
…in executorspage.test.js ### What changes were proposed in this pull request? Fix the jQuery import path in `ui-test/tests/executorspage.test.js` on `branch-4.1`, changing `jquery.min.js` to `jquery-3.5.1.min.js`. ### Why are the changes needed? The `executorspage.test.js` added by SPARK-58158 imports `jquery.min.js`. That file name only exists on `master`, where SPARK-54235 (a master-only jQuery 3.5.1 -> 3.7.1 upgrade) renamed `jquery-3.5.1.min.js` to the version-agnostic `jquery.min.js`. SPARK-54235 was not backported, so on `branch-4.1` the file is still `jquery-3.5.1.min.js` and the import fails: ``` FAIL tests/executorspage.test.js Cannot find module '.../ui/static/jquery.min.js' from 'tests/executorspage.test.js' ``` This breaks the daily "Run Spark UI tests" job on `branch-4.1` (e.g. https://github.com/apache/spark/actions/runs/29675755877/job/88162850620). The other three ui-test files on this branch already import `jquery-3.5.1.min.js`; this aligns `executorspage.test.js` with them. The `jquery.dataTables.min.js` import on the following line is unaffected (that file exists on the branch). ### Does this PR introduce _any_ user-facing change? No. Test-only. ### How was this patch tested? Ran the ui-test suite locally on `branch-4.1` with the fix: ``` cd ui-test npm install --save-dev node --experimental-vm-modules node_modules/.bin/jest Test Suites: 5 passed, 5 total Tests: 13 passed, 13 total ``` ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57393 from LuciferYang/SPARK-58158-jquery-41. Authored-by: YangJie <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merge Summary:
Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the jQuery import path in
ui-test/tests/executorspage.test.jsonbranch-4.1, changingjquery.min.jstojquery-3.5.1.min.js.Why are the changes needed?
The
executorspage.test.jsadded by SPARK-58158 importsjquery.min.js. That file name only exists onmaster, where SPARK-54235 (a master-only jQuery 3.5.1 -> 3.7.1 upgrade) renamedjquery-3.5.1.min.jsto the version-agnosticjquery.min.js. SPARK-54235 was not backported, so onbranch-4.1the file is stilljquery-3.5.1.min.jsand the import fails:This breaks the daily "Run Spark UI tests" job on
branch-4.1(e.g. https://github.com/apache/spark/actions/runs/29675755877/job/88162850620). The other three ui-test files on this branch already importjquery-3.5.1.min.js; this alignsexecutorspage.test.jswith them. Thejquery.dataTables.min.jsimport on the following line is unaffected (that file exists on the branch).Does this PR introduce any user-facing change?
No. Test-only.
How was this patch tested?
Ran the ui-test suite locally on
branch-4.1with the fix:Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)