Skip to content

[SPARK-58355][SS] Fix grammar in metadata log null-check message #57546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uros-b wants to merge 1 commit into from
Closed

[SPARK-58355][SS] Fix grammar in metadata log null-check message #57546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...main/scala/org/apache/spark/sql/execution/streaming/checkpointing/AsyncOffsetSeqLog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class AsyncOffsetSeqLog(
* to indicate some write error.
*/
def addAsync(batchId: Long, metadata: OffsetSeqBase): CompletableFuture[(Long, Boolean)] = {
require(metadata != null, "'null' metadata cannot written to a metadata log")
require(metadata != null, "'null' metadata cannot be written to a metadata log")

def issueAsyncWrite(batchId: Long): CompletableFuture[Long] = {
lastCommitIssuedTimestampMs.set(clock.getTimeMillis())
Expand Down
2 changes: 1 addition & 1 deletion ...c/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/HDFSMetadataLog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class HDFSMetadataLog[T <: AnyRef : ClassTag](
* metadata has already been stored, this method will return `false`.
*/
override def add(batchId: Long, metadata: T): Boolean = {
require(metadata != null, "'null' metadata cannot written to a metadata log")
require(metadata != null, "'null' metadata cannot be written to a metadata log")
val res = addNewBatchByStream(batchId) { output => serialize(metadata, output) }
if (metadataCacheEnabled && res) batchCache.put(batchId, metadata)
res
Expand Down