Skip to content

[SPARK-8531] [ML] Update ML user guide for MinMaxScaler#7211

Closed
hhbyyh wants to merge 5 commits into
apache:masterfrom
hhbyyh:minmaxdoc
Closed

[SPARK-8531] [ML] Update ML user guide for MinMaxScaler#7211
hhbyyh wants to merge 5 commits into
apache:masterfrom
hhbyyh:minmaxdoc

Conversation

@hhbyyh

@hhbyyh hhbyyh commented Jul 3, 2015

Copy link
Copy Markdown
Contributor

jira: https://issues.apache.org/jira/browse/SPARK-8531

Update ML user guide for MinMaxScaler

@SparkQA

SparkQA commented Jul 3, 2015

Copy link
Copy Markdown

Test build #36492 has finished for PR 7211 at commit a0725a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Aug 3, 2015

Copy link
Copy Markdown

Test build #39525 has finished for PR 7211 at commit 40942a7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Comment thread docs/ml-features.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@jkbradley

Copy link
Copy Markdown
Member

Would you mind adding an example for Python too? Or we can make that a separate PR if you prefer.

@SparkQA

SparkQA commented Aug 13, 2015

Copy link
Copy Markdown

Test build #40741 has finished for PR 7211 at commit b6ac0fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hhbyyh

hhbyyh commented Aug 13, 2015

Copy link
Copy Markdown
Contributor Author

@jkbradley Thanks for the review.
I'm not sure if the latex part looks good.
And for python document, since python interface for MinMaxScaler is still under review, so I didn't add the example.

Comment thread docs/ml-features.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are not generated correctly, but you can fix it by modifying this line:

<div data-lang="scala" markdown="1">

@jkbradley

Copy link
Copy Markdown
Member

The latex part looks much better now.

@jkbradley

Copy link
Copy Markdown
Member

ping!

@hhbyyh

hhbyyh commented Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

Sorry for the delay. I am in my hometown and has poor internet connection. I'll be back to office tomorrow and start catching up.

@SparkQA

SparkQA commented Aug 24, 2015

Copy link
Copy Markdown

Test build #41489 has finished for PR 7211 at commit 1622f85.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley

Copy link
Copy Markdown
Member

Thank you for updating it. LGTM.
Merging with master and branch-1.5

asfgit pushed a commit that referenced this pull request Aug 25, 2015
jira: https://issues.apache.org/jira/browse/SPARK-8531

Update ML user guide for MinMaxScaler

Author: Yuhao Yang <hhbyyh@gmail.com>
Author: unknown <yuhaoyan@yuhaoyan-MOBL1.ccr.corp.intel.com>

Closes #7211 from hhbyyh/minmaxdoc.

(cherry picked from commit b37f0cc)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in b37f0cc Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants