Skip to content

[SPARK 9902] [MLlib] Add Java and Python examples to user guide for 1-sample KS test#8154

Closed
josepablocam wants to merge 3 commits into
apache:masterfrom
josepablocam:spark_9902
Closed

[SPARK 9902] [MLlib] Add Java and Python examples to user guide for 1-sample KS test#8154
josepablocam wants to merge 3 commits into
apache:masterfrom
josepablocam:spark_9902

Conversation

@josepablocam

Copy link
Copy Markdown

added doc examples for python.

@mengxr

mengxr commented Aug 14, 2015

Copy link
Copy Markdown
Contributor

add to whitelist

@mengxr

mengxr commented Aug 14, 2015

Copy link
Copy Markdown
Contributor

ok to test

@SparkQA

SparkQA commented Aug 14, 2015

Copy link
Copy Markdown

Test build #40850 has finished for PR 8154 at commit 1bad75f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Comment thread docs/mllib-statistics.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data = sc.parallelize([1.0, 2.0, ...]) should be sufficient.

@mengxr

mengxr commented Aug 14, 2015

Copy link
Copy Markdown
Contributor

@josepablocam

Copy link
Copy Markdown
Author

@mengxr added Java example now, thanks!

@josepablocam josepablocam changed the title [SPARK 9902] [MLlib] [WIP] Add Java and Python examples to user guide for 1-sample KS test [SPARK 9902] [MLlib] Add Java and Python examples to user guide for 1-sample KS test Aug 14, 2015
@SparkQA

SparkQA commented Aug 14, 2015

Copy link
Copy Markdown

Test build #40928 has finished for PR 8154 at commit b914058.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StringIndexerModel (
    • implicit class StringToColumn(val sc: StringContext)

Comment thread docs/mllib-statistics.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: We can use Arrays.asList to replace Lists.newArrayList. The former is from Java core, which doesn't require additional dependencies. Then we can replace import com.google.common.collect.Lists; by import java.util.Arrays;. Btw, please insert an empty line between Java imports and Spark imports.

@mengxr

mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

LGTM except minor inline comments.

… fixed python link. Made 1 additional fix from a typo
@josepablocam

Copy link
Copy Markdown
Author

@mengxr thanks for the feedback. Fixed

@mengxr

mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

LGTM. Merged into master and branch-1.5. Thanks! (Skipped Jenkins because this is doc-only.)

@asfgit asfgit closed this in c90c605 Aug 18, 2015
asfgit pushed a commit that referenced this pull request Aug 18, 2015
…-sample KS test

added doc examples for python.

Author: jose.cambronero <jose.cambronero@cloudera.com>

Closes #8154 from josepablocam/spark_9902.

(cherry picked from commit c90c605)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@SparkQA

SparkQA commented Aug 18, 2015

Copy link
Copy Markdown

Test build #41086 has finished for PR 8154 at commit 7763712.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants