[SPARK-9927][SQL]Revert 8049 since it's pushing wrong filter down#8157
Closed
yjshen wants to merge 1 commit into
Closed
[SPARK-9927][SQL]Revert 8049 since it's pushing wrong filter down#8157yjshen wants to merge 1 commit into
yjshen wants to merge 1 commit into
Conversation
Contributor
|
@yjshen Could you provide a snippet that reproduces the error you mentioned? |
Member
Author
|
|
|
Test build #40723 has finished for PR 8157 at commit
|
Contributor
|
@yjshen Thanks, I'm merging this to master and branch-1.5 and reopening SPARK-9182. |
asfgit
pushed a commit
that referenced
this pull request
Aug 13, 2015
I made a mistake in #8049 by casting literal value to attribute's data type, which would cause simply truncate the literal value and push a wrong filter down. JIRA: https://issues.apache.org/jira/browse/SPARK-9927 Author: Yijie Shen <henry.yijieshen@gmail.com> Closes #8157 from yjshen/rever8049. (cherry picked from commit d0b1891) Signed-off-by: Cheng Lian <lian@databricks.com>
Member
Author
|
@liancheng , I'm really sorry for my mistake. |
Contributor
|
Nah, I suggested the wrong fix at the first place anyway :) |
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
I made a mistake in apache#8049 by casting literal value to attribute's data type, which would cause simply truncate the literal value and push a wrong filter down. JIRA: https://issues.apache.org/jira/browse/SPARK-9927 Author: Yijie Shen <henry.yijieshen@gmail.com> Closes apache#8157 from yjshen/rever8049.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake in #8049 by casting literal value to attribute's data type, which would cause simply truncate the literal value and push a wrong filter down.
JIRA: https://issues.apache.org/jira/browse/SPARK-9927