[SPARK-10038] [SQL] fix bug in generated unsafe projection when there is binary in ArrayData#8250
Closed
davies wants to merge 2 commits into
Closed
[SPARK-10038] [SQL] fix bug in generated unsafe projection when there is binary in ArrayData#8250davies wants to merge 2 commits into
davies wants to merge 2 commits into
Conversation
Contributor
|
Jenkins, retest this please. |
|
Test build #41054 has finished for PR 8250 at commit
|
|
Test build #1636 has finished for PR 8250 at commit
|
|
Test build #41058 has finished for PR 8250 at commit
|
Contributor
|
Ah good catch! The change LGTM. Not related to this PR, but as we have more and more hack(equals, hashCode, etc.) for binary type, should we create a wrapper class for it? |
Contributor
|
I've merged this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type for array of array in Java is slightly different than array of others.
cc @cloud-fan