Skip to content

[SPARK-7808] [ML] add package doc for ml.feature#8260

Closed
mengxr wants to merge 2 commits into
apache:masterfrom
mengxr:SPARK-7808
Closed

[SPARK-7808] [ML] add package doc for ml.feature#8260
mengxr wants to merge 2 commits into
apache:masterfrom
mengxr:SPARK-7808

Conversation

@mengxr

@mengxr mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

This PR adds a short description of ml.feature package with code example. The Java package doc will come in a separate PR. @jkbradley

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"most scikit-learn's" --> "most scikit-learn"

@jkbradley

Copy link
Copy Markdown
Member

Include link to online API doc?

@jkbradley

Copy link
Copy Markdown
Member

Other than that, LGTM
(I generated it, and ran the example)

@SparkQA

SparkQA commented Aug 18, 2015

Copy link
Copy Markdown

Test build #41078 has finished for PR 8260 at commit 8b1880b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr

mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor Author

We don't have a dedicated user guide section for ml.feature yet. So I didn't provide a link.

@SparkQA

SparkQA commented Aug 18, 2015

Copy link
Copy Markdown

Test build #41085 has finished for PR 8260 at commit 425aad2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr

mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor Author

Merged into master and branch-1.5.

@asfgit asfgit closed this in e290029 Aug 18, 2015
asfgit pushed a commit that referenced this pull request Aug 18, 2015
This PR adds a short description of `ml.feature` package with code example. The Java package doc will come in a separate PR. jkbradley

Author: Xiangrui Meng <meng@databricks.com>

Closes #8260 from mengxr/SPARK-7808.

(cherry picked from commit e290029)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@jkbradley

Copy link
Copy Markdown
Member

I was suggesting the API guide, not the user guide (but we actually do have a user guide section as well: ml-feature.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants