Skip to content

[SPARK-10076] [ML] make MultilayerPerceptronClassifier layers and weights public#8263

Closed
yanboliang wants to merge 1 commit into
apache:masterfrom
yanboliang:mlp-public
Closed

[SPARK-10076] [ML] make MultilayerPerceptronClassifier layers and weights public#8263
yanboliang wants to merge 1 commit into
apache:masterfrom
yanboliang:mlp-public

Conversation

@yanboliang

Copy link
Copy Markdown
Contributor

Fix the issue that layers and weights should be public variables of MultilayerPerceptronClassificationModel. Users can not get layers and weights from a MultilayerPerceptronClassificationModel currently.

@mengxr

mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

This changes public API. Could you make a JIRA as well?

@yanboliang yanboliang changed the title [ML] makes MultilayerPerceptronClassifier layers and weights public [SPARK-10076] [ML] make MultilayerPerceptronClassifier layers and weights public Aug 18, 2015
@yanboliang

Copy link
Copy Markdown
Contributor Author

@mengxr SPARK-10076

@mengxr

mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

LGTM pending Jenkins.

@SparkQA

SparkQA commented Aug 18, 2015

Copy link
Copy Markdown

Test build #41087 has finished for PR 8263 at commit 7431251.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

asfgit pushed a commit that referenced this pull request Aug 18, 2015
…ghts public

Fix the issue that ```layers``` and ```weights``` should be public variables of ```MultilayerPerceptronClassificationModel```. Users can not get ```layers``` and ```weights``` from a ```MultilayerPerceptronClassificationModel``` currently.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #8263 from yanboliang/mlp-public.

(cherry picked from commit dd0614f)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr

mengxr commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in dd0614f Aug 18, 2015
@yanboliang yanboliang deleted the mlp-public branch August 26, 2015 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants