[SPARK-9758] [TEST] [SQL] Compilation issue for hive test / wrong package?

[srowen]

Move test.org.apache.spark.sql.hive package tests to apparent intended org.apache.spark.sql.hive as they don't intend to test behavior from outside org.apache.spark.*

Alternate take, per discussion at #8051
I think this is what @vanzin and I had in mind but also CC @rxin to cross-check, as this does indeed depend on whether these tests were accidentally in this package or not. Testing from a test.org.apache.spark package is legitimate but didn't seem to be the intent here.

[SparkQA]

Test build #41405 has finished for PR 8307 at commit 7379cd9.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • public class JavaDataFrameSuite
  • public class JavaMetastoreDataSourcesSuite
  • public class MyDoubleAvg extends UserDefinedAggregateFunction
  • public class MyDoubleSum extends UserDefinedAggregateFunction
  • public class UDFIntegerToString extends UDF
  • public class UDFListListInt extends UDF
  • public class UDFListString extends UDF
  • public class UDFStringString extends UDF
  • public class UDFTwoListList extends UDF

[srowen]

I'd like to commit this one for 1.6, at least. I think it's worth moving into the apparent right place for 1.5 too to avoid merge conflicts and make sure the test is working as it seems to be intended to.

[vanzin]

LGTM, but it would be nice to hear from the original author what was the intent here. @chenghao-intel?

[rxin]

Actually I told @chenghao-intel to do this.

JavaDataFrameSuite should be in test.org.apache.spark.sql.hive. There was a case in which the JavaDataFrameSuite was testing a private[spark] or private[sql] method and assuming it was public.

[rxin]

Discussed a bit with @srowen offline about this. It would be better to move all the API tests (e.g. RDDSuite, DataFrameSuite) to test.org.apache.spark, in order to properly test visibility. This is more useful in Scala than Java.

[srowen]

Yeah I think the offline conclusion was -- go ahead with this to at least put things in a standardized state, and later break out API tests.