Fixed a typo in DAGScheduler.

[zzvara]

No description provided.

[sarutak]

ok to test.

[srowen]

Yeah, pretty trivial but true. Same for taskSetFailed I think.
Also executorLost and executorAdded could probably refer to a "TaskScheduler implementation" to be more accurate.

[zzvara]

Would you like if I go through all of them?
Okay, I will.

[srowen]

I think the additional changes I mentioned are worth fixing here since they're very much of the same form. If you have time to scan for similar problems in nearby source, that's fine, but fixing all the related issues in this file seems like a good logical change.

[SparkQA]

Test build #41234 has finished for PR 8308 at commit 2a70faf.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[zzvara]

I went through it, also reorganized a method to the front and made method comments consistent.

[srowen]

I'm not sure all of this should be scaladoc. This looks like a private comment in the source code. Same for "Broken out for easier testing..."

[SparkQA]

Test build #41325 has finished for PR 8308 at commit 4911559.

• This patch fails to build.
• This patch does not merge cleanly.
• This patch adds no public classes.

[srowen]

Why was this changed? it's not a big deal, but it was OK on one line. Changes always have this small but non-zero chance of tangling up a merge later, so trivial changes are usually avoided

[zzvara]

I guess it must have been going over 100 in length.

[srowen]

Oh right, because of the extra word. That's fine.
PS You'll need to rebase this branch on master

[SparkQA]

Test build #41326 has finished for PR 8308 at commit 100f9a7.

• This patch fails to build.
• This patch does not merge cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #41450 timed out for PR 8308 at commit f835ae8 after a configured wait of 175m.

[srowen]

The changes here that just make scaladoc into a multiline comment don't do anything .. it's still valid on one line. I think the other changes look fine, and this is a no-op at best, but personally would not change these lines if there is no functional change.

[srowen]

LGTM

[SparkQA]

Test build #41529 has finished for PR 8308 at commit 73ce4ac.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

The test failure must be spurious; this is a scaladoc-only change, and compilation / style checks succeed.