Skip to content

[SPARK-10378][SQL][Test] Remove HashJoinCompatibilitySuite.#8542

Closed
rxin wants to merge 1 commit into
apache:masterfrom
rxin:SPARK-10378
Closed

[SPARK-10378][SQL][Test] Remove HashJoinCompatibilitySuite.#8542
rxin wants to merge 1 commit into
apache:masterfrom
rxin:SPARK-10378

Conversation

@rxin

@rxin rxin commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

They don't bring much value since we now have better unit test coverage for hash joins. This will also help reduce the test time.

@vanzin

vanzin commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

I have a different approach in #8437 (which doesn't get rid of the tests here).

@rxin

rxin commented Aug 31, 2015

Copy link
Copy Markdown
Contributor Author

@vanzin we can have both, can't we? I don't think HashJoinCompatibilitySuite is testing much here, given we added more tests for hash joins. In general, operator tests should be done not at the end-to-end level. The Hive tests are great in the beginning to beef up our test coverage with little effort, but their values are decreasing everyday.

@vanzin

vanzin commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

Sure, I was just wondering because the reasoning on the bug is "to make the tests run faster" and not "the test doesn't really add value".

@SparkQA

SparkQA commented Sep 1, 2015

Copy link
Copy Markdown

Test build #41843 has finished for PR 8542 at commit 46b7112.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in d65656c Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants