Skip to content

[SPARK-10353] [MLLIB] (1.3 backport) BLAS gemm not scaling when beta = 0.0 for some subset of matrix multiplications#8572

Closed
srowen wants to merge 1 commit into
apache:branch-1.3from
srowen:SPARK-10353.2
Closed

[SPARK-10353] [MLLIB] (1.3 backport) BLAS gemm not scaling when beta = 0.0 for some subset of matrix multiplications#8572
srowen wants to merge 1 commit into
apache:branch-1.3from
srowen:SPARK-10353.2

Conversation

@srowen

@srowen srowen commented Sep 2, 2015

Copy link
Copy Markdown
Member

Apply fixes for alpha, beta parameter handling in gemm/gemv from #8525 to branch 1.3

CC @mengxr @brkyvz

@SparkQA

SparkQA commented Sep 2, 2015

Copy link
Copy Markdown

Test build #41931 has finished for PR 8572 at commit d1fa2be.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41931/
Test FAILed.

@srowen

srowen commented Sep 2, 2015

Copy link
Copy Markdown
Member Author

I think it actually passed, but not sure what to make of the conflicting messages from Jenkins here

asfgit pushed a commit that referenced this pull request Sep 2, 2015
…= 0.0 for some subset of matrix multiplications

Apply fixes for alpha, beta parameter handling in gemm/gemv from #8525 to branch 1.3

CC mengxr brkyvz

Author: Sean Owen <sowen@cloudera.com>

Closes #8572 from srowen/SPARK-10353.2.
@mengxr

mengxr commented Sep 2, 2015

Copy link
Copy Markdown
Contributor

LGTM and confirmed that Jenkins build passed. Merged into branch-1.3. Thanks!

@mengxr

mengxr commented Sep 2, 2015

Copy link
Copy Markdown
Contributor

Btw, please close this PR manually.

@srowen srowen closed this Sep 2, 2015
@srowen srowen deleted the SPARK-10353.2 branch September 9, 2015 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants