[SPARK-9996][SPARK-9997][SQL]Add local expand and NestedLoopJoin operators#8642
Closed
zsxwing wants to merge 7 commits into
Closed
[SPARK-9996][SPARK-9997][SQL]Add local expand and NestedLoopJoin operators#8642zsxwing wants to merge 7 commits into
zsxwing wants to merge 7 commits into
Conversation
|
Test build #42095 has finished for PR 8642 at commit
|
Contributor
There was a problem hiding this comment.
hm, at this point input hasn't been initialized yet has it? Did you intend to pass null into the projection?
|
Test build #42330 has finished for PR 8642 at commit
|
|
Test build #42336 has finished for PR 8642 at commit
|
Contributor
There was a problem hiding this comment.
how about:
if (idx < 0 || idx >= groups.length) {
if (child.next()) {
input = child.fetch()
idx = 0
} else {
return false
}
}
result = groups(idx)(input)
idx += 1
true
a little less duplication
Contributor
|
@zsxwing I left some suggestions on reducing code duplication, but otherwise this looks pretty good. |
Member
Author
|
@andrewor14 thanks for your reviewing. I updated this PR as per your comments. |
|
Test build #42421 has finished for PR 8642 at commit
|
Contributor
|
LGTM, thanks I'm merging this into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in conflict with #8535 and #8573. Will update this one when they are merged.