Skip to content

[SPARK-10573] [ML] IndexToString output schema should be StringType#8751

Closed
pnpritchard wants to merge 1 commit into
apache:masterfrom
pnpritchard:SPARK-10573
Closed

[SPARK-10573] [ML] IndexToString output schema should be StringType#8751
pnpritchard wants to merge 1 commit into
apache:masterfrom
pnpritchard:SPARK-10573

Conversation

@pnpritchard

Copy link
Copy Markdown

Fixes bug where IndexToString output schema was DoubleType. Correct me if I'm wrong, but it doesn't seem like the output needs to have any "ML Attribute" metadata.

@mengxr

mengxr commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

ok to test

@mengxr

mengxr commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

LGTM pending Jenkins.

@SparkQA

SparkQA commented Sep 14, 2015

Copy link
Copy Markdown

Test build #42435 has finished for PR 8751 at commit b9577e8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 8a634e9 Sep 14, 2015
@mengxr

mengxr commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

LGTM. Merged into master and branch-1.5. Thanks!

asfgit pushed a commit that referenced this pull request Sep 14, 2015
Fixes bug where IndexToString output schema was DoubleType. Correct me if I'm wrong, but it doesn't seem like the output needs to have any "ML Attribute" metadata.

Author: Nick Pritchard <nicholas.pritchard@falkonry.com>

Closes #8751 from pnpritchard/SPARK-10573.

(cherry picked from commit 8a634e9)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@pnpritchard pnpritchard deleted the SPARK-10573 branch September 15, 2015 20:15
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
Fixes bug where IndexToString output schema was DoubleType. Correct me if I'm wrong, but it doesn't seem like the output needs to have any "ML Attribute" metadata.

Author: Nick Pritchard <nicholas.pritchard@falkonry.com>

Closes apache#8751 from pnpritchard/SPARK-10573.

(cherry picked from commit 8a634e9)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
(cherry picked from commit 5b7067c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants