Skip to content

Fixing a bug related to following exception #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ErangaHeshan wants to merge 1 commit into from
Closed

Fixing a bug related to following exception #1799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storm-core/src/jvm/org/apache/storm/stats/StatsUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,7 +1516,7 @@ public static List<Map<String, Object>> extractNodeInfosFromHbForComp(

Integer start = ((Number) key.get(0)).intValue();
String host = (String) value.get(0);
Integer port = (Integer) value.get(1);
Integer port = (Long) value.get(1);

@srdo srdo Nov 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably better to do this like in L1517. That way it doesn't matter if the actual object is an Integer or Long.

@ErangaHeshan ErangaHeshan Nov 27, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be much better. Hope you fixed it 👍

@HeartSaVioR HeartSaVioR Nov 30, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErangaHeshan
Let's follow what @srdo comments. Could you address it?

String comp = (String) task2component.get(start);
if ((compId == null || compId.equals(comp)) && (includeSys || !Utils.isSystemId(comp))) {
hostPorts.add(Lists.newArrayList(host, port));
Expand Down