STORM-2264 OpaqueTridentKafkaSpout failing after STORM-2216#1853
Merged
Conversation
* use JSONValue.parse() instead of JSONValue.parseWithException() in TransactionState * this just rolls back to previous, doesn't provide better approach
Contributor
|
+1 |
Contributor
Author
|
@revans2 Could you please take a look? |
Contributor
|
+1 seems fine to me |
Contributor
|
I am also OK with reverting STORM-2216 if it is causing a lot of issues. |
Contributor
Author
|
@revans2 I think the direction of STORM-2216 is right, and we just found a spot which is not trivial to fix to the right way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that this is just a quick and dirty fix given that the priority of STORM-2264 is critical.
Even after merging this, we should find better solution and apply soon. (#1844 is one of)