STORM-2508:storm-solr enhancement: update solrj to 5.5, support custom SolrClientFactory and commit operation by aylei · Pull Request #2108 · apache/storm

aylei · 2017-05-10T15:05:52Z

I have a case that the SolrCloud in my organization is protected by SSL + Basic Auth, so I need to provide customized SolrClient instance to SolrUpdateBolt. Likewise, the RestJsonSchemaBuilder cannot access Schema API without auth.
In addition, for "near real-time search", soft commit is preferred, so it is better to expose an interface for user to customize commit operation.
I think those features will also be useful for other people who needs to use custom SolrClient implementation and control the detail of commit operation. So, finally, I plan an enhancement for storm-solr:

update solrj and related dependencies to 5.5;
improve SolrConfig to support custom SolrClientFactory and CommitCallBack;
provide a SchemaBuilder implementation which use custom SolrClient to request Schema API;
elder SolrUpdateBolts intend to commit when recieve a tick, but by default BaseTickTupleAwareRichBolt will ignore tick, this PR also fix it.

storm-solr enhancement: update solrj to 5.5, support custom SolrClientFactory and commit operation

srdo

Thanks for the contribution @AleiHanami. I left a few comments, but the changes look reasonable. Could you open a PR against master as well, since we need changes to go there first?

srdo · 2017-08-12T06:23:51Z

@@ -0,0 +1,30 @@
+/*
+ * DefaultCloudSolrClientFactory.java


Please replace this license header with the Apache header (copy it from one of the other files)

srdo · 2017-08-12T06:24:56Z

+ * default implementation of {@link SolrClientFactory}, which takes a zookeeper host
+ * and produce {@link org.apache.solr.client.solrj.impl.CloudSolrClient} with the host.
+ *
+ * @author alei


Please remove the author.

srdo · 2017-08-12T06:33:18Z

+import java.util.Map;
+
+/**
+ * <p>this Class build the {@link Schema} by Solr Schema API.</p>


Is there any reason to prefer the REST schema builder over this one? Otherwise maybe we should remove the other one?

srdo · 2017-08-12T06:38:34Z

+        Schema converted = new Schema();
+        converted.setUniqueKey(representation.getUniqueKey());
+        converted.setName(representation.getName());
+        converted.setVersion(String.valueOf(representation.getVersion()));


Nit: If this is a float, shouldn't we keep it that way in Schema?

srdo · 2017-08-12T06:43:07Z

+            FieldType fieldType = new FieldType();
+            fieldType.setClazz(type.getAttributes().get("class").toString());
+            if (type.getAttributes().get("multiValued") != null) {
+                fieldType.setMultiValued(Boolean.valueOf(type.getAttributes().get("multiValued").toString()));


Is this attribute already a boolean? If so I don't think there's a reason to toString and then Boolean.valueOf it.

srdo · 2017-08-12T06:44:50Z

+                new ArrayList<>(representation.getFields().size());
+        for (Map<String, Object> field : representation.getFields()) {
+            org.apache.storm.solr.schema.Field schemaField = new org.apache.storm.solr.schema.Field();
+            schemaField.setName(field.get("name").toString());


Nit: An explicit cast to String might be nicer here, so you get an exception in case this isn't a String for some reason.

srdo · 2017-08-12T06:46:12Z

+        return schema;
+    }
+
+    private Schema convert(final SchemaRepresentation representation) {


Nit: It might be good to add a unit test for this, to verify that this conversion does the right thing.

srdo · 2017-08-12T06:49:42Z

+ */
+public interface CommitCallback extends Serializable {
+
+    void process(SolrClient solrClient, String collection) throws SolrServerException, IOException;


Nit: Shouldn't this be named "commit"?

sachingsachin · 2017-08-12T18:11:48Z

            <groupId>org.apache.solr</groupId>
            <artifactId>solr-solrj</artifactId>
-            <version>5.2.1</version>
+            <version>5.5.0</version>


5.5.0 version is affected by a security problem and is also more than 1.5 years old.
http://lucene.apache.org/solr/news.html
Please consider moving to Solr 6.5.1 or 6.6.0

sachingsachin · 2017-08-12T18:12:29Z

            <groupId>org.apache.solr</groupId>
            <artifactId>solr-test-framework</artifactId>
-            <version>5.2.1</version>
+            <version>5.5.0</version>


To avoiding adding version everywhere, this should be made a property

sachingsachin

Solr version changes requested

We are closing stale Pull Requests to make the list more manageable. Please re-open any Pull Request that has been closed in error. Closes apache#608 Closes apache#639 Closes apache#640 Closes apache#648 Closes apache#662 Closes apache#668 Closes apache#692 Closes apache#705 Closes apache#724 Closes apache#728 Closes apache#730 Closes apache#753 Closes apache#803 Closes apache#854 Closes apache#922 Closes apache#986 Closes apache#992 Closes apache#1019 Closes apache#1040 Closes apache#1041 Closes apache#1043 Closes apache#1046 Closes apache#1051 Closes apache#1078 Closes apache#1146 Closes apache#1164 Closes apache#1165 Closes apache#1178 Closes apache#1213 Closes apache#1225 Closes apache#1258 Closes apache#1259 Closes apache#1268 Closes apache#1272 Closes apache#1277 Closes apache#1278 Closes apache#1288 Closes apache#1296 Closes apache#1328 Closes apache#1342 Closes apache#1353 Closes apache#1370 Closes apache#1376 Closes apache#1391 Closes apache#1395 Closes apache#1399 Closes apache#1406 Closes apache#1410 Closes apache#1422 Closes apache#1427 Closes apache#1443 Closes apache#1462 Closes apache#1468 Closes apache#1483 Closes apache#1506 Closes apache#1509 Closes apache#1515 Closes apache#1520 Closes apache#1521 Closes apache#1525 Closes apache#1527 Closes apache#1544 Closes apache#1550 Closes apache#1566 Closes apache#1569 Closes apache#1570 Closes apache#1575 Closes apache#1580 Closes apache#1584 Closes apache#1591 Closes apache#1600 Closes apache#1611 Closes apache#1613 Closes apache#1639 Closes apache#1703 Closes apache#1711 Closes apache#1719 Closes apache#1737 Closes apache#1760 Closes apache#1767 Closes apache#1768 Closes apache#1785 Closes apache#1799 Closes apache#1822 Closes apache#1824 Closes apache#1844 Closes apache#1874 Closes apache#1918 Closes apache#1928 Closes apache#1937 Closes apache#1942 Closes apache#1951 Closes apache#1957 Closes apache#1963 Closes apache#1964 Closes apache#1965 Closes apache#1967 Closes apache#1968 Closes apache#1971 Closes apache#1985 Closes apache#1986 Closes apache#1998 Closes apache#2031 Closes apache#2032 Closes apache#2071 Closes apache#2076 Closes apache#2108 Closes apache#2119 Closes apache#2128 Closes apache#2142 Closes apache#2174 Closes apache#2206 Closes apache#2297 Closes apache#2322 Closes apache#2332 Closes apache#2341 Closes apache#2377 Closes apache#2414 Closes apache#2469

STORM-2508

e338fc6

storm-solr enhancement: update solrj to 5.5, support custom SolrClientFactory and commit operation

srdo reviewed Aug 12, 2017

View reviewed changes

sachingsachin reviewed Aug 12, 2017

View reviewed changes

d2r mentioned this pull request Oct 16, 2018

STORM-3250: Closes Pull Requests unchanged in 2018 #2880

Merged

asfgit closed this in #2880 Oct 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

STORM-2508:storm-solr enhancement: update solrj to 5.5, support custom SolrClientFactory and commit operation#2108

STORM-2508:storm-solr enhancement: update solrj to 5.5, support custom SolrClientFactory and commit operation#2108
aylei wants to merge 1 commit into
apache:1.x-branchfrom
aylei:client-enhance

aylei commented May 10, 2017 •

edited

Loading

Uh oh!

srdo left a comment

Uh oh!

srdo Aug 12, 2017

Uh oh!

srdo Aug 12, 2017

Uh oh!

srdo Aug 12, 2017

Uh oh!

srdo Aug 12, 2017

Uh oh!

srdo Aug 12, 2017

Uh oh!

srdo Aug 12, 2017

Uh oh!

srdo Aug 12, 2017

Uh oh!

srdo Aug 12, 2017

Uh oh!

sachingsachin Aug 12, 2017

Uh oh!

sachingsachin Aug 12, 2017

Uh oh!

sachingsachin left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

aylei commented May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srdo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sachingsachin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aylei commented May 10, 2017 •

edited

Loading