[STORM-2093] Fix permissions in multi-tenant, secure mode#2187
Merged
Conversation
Contributor
Author
|
@revans2 Yes, I tested it manually. |
knusbaum
reviewed
Jul 5, 2017
| (resp/status 404))))) | ||
|
|
||
| (defnk set-log-file-permissions [fname root-dir] | ||
| (let [file (.getCanonicalFile (File. root-dir fname)) |
Contributor
There was a problem hiding this comment.
Indentation on this function is off.
Contributor
Author
There was a problem hiding this comment.
Thanks. Will fix it quickly
knusbaum
reviewed
Jul 5, 2017
| parent (.getParent (File. root-dir fname)) | ||
| md-file (if (nil? parent) nil (get-metadata-file-for-wroker-logdir parent)) | ||
| topo-owner (if (nil? md-file) nil (get-topo-owner-from-metadata-file (.getCanonicalPath md-file)))] | ||
| (if (and run-as-user |
Contributor
There was a problem hiding this comment.
Nit: since there is no 'else' branch, replacing if with when will allow you to remove the do.
Contributor
Author
There was a problem hiding this comment.
Thanks. Will fix it quickly
Contributor
|
+1 |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heap dumps created on OOM, when served through the logviewer in secure multi-tenant configurations have permissions set such that the logviewer cannot read them.
This change checks permissions in this case before serving and then runs the worker-launcher to enable the logviewer to serve them.
see #2032