[STORM-2753] Avoid shutting down netty server on netty exception#2340
Closed
Ethanlm wants to merge 1 commit into
Closed
[STORM-2753] Avoid shutting down netty server on netty exception#2340Ethanlm wants to merge 1 commit into
Ethanlm wants to merge 1 commit into
Conversation
Contributor
Author
|
Test failed in org.apache.storm.st.tests.window.TumblingWindowTest.testTumbleCount seems unrelated. |
Contributor
|
Storm is designed as fail-fast, and all exceptions which we should catch and handle should not go there. So if it reaches to NettyUncaughtExceptionHandler, I think there's nothing to do. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA-STORM-2753
NettyUncaughtExceptionHandlershould only exit if there is anError