Skip to content

fix(embedded): resolve guest user permissions (backports #39197) - #42768

Closed
luizotavio32 wants to merge 3 commits into
apache:6.2from
luizotavio32:fix/backport-39197-guest-perms-6.2
Closed

fix(embedded): resolve guest user permissions (backports #39197)#42768
luizotavio32 wants to merge 3 commits into
apache:6.2from
luizotavio32:fix/backport-39197-guest-perms-6.2

Conversation

@luizotavio32

@luizotavio32 luizotavio32 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

SUMMARY

Backports #39197 to 6.2. Cherry-picked from 041ecbc248 with no adaptation, diff is identical to the original commit.

See #39197 for the rationale.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable — no UI change.

TESTING INSTRUCTIONS

pytest tests/unit_tests/security/manager_test.py

41 pass, including the 2 tests the original commit adds (pytest ... -k user_view_menu_names).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: EMBEDDED_SUPERSET
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…apache#39197)

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Claude Code <noreply@anthropic.com>
(cherry picked from commit 041ecbc)
@bito-code-review

bito-code-review Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

@luizotavio32

Copy link
Copy Markdown
Contributor Author

/review

@bito-code-review

bito-code-review Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #32bf7a

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: e2c4e12..e2c4e12
    • superset/security/manager.py
    • tests/unit_tests/security/manager_test.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@luizotavio32 luizotavio32 changed the title fix(embedded): resolve guest user permissions in user_view_menu_names… fix(embedded): resolve guest user permissions in user_view_menu_names (backport #39197 to 6.2) Aug 5, 2026
@luizotavio32 luizotavio32 changed the title fix(embedded): resolve guest user permissions in user_view_menu_names (backport #39197 to 6.2) fix(embedded): resolve guest user permissions (backports #39197) Aug 5, 2026
@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit e2c4e12
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a72a6b1e16e200007935088
😎 Deploy Preview https://deploy-preview-42768--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (6.2@a812670). Learn more about missing BASE report.

Files with missing lines Patch % Lines
superset/security/manager.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             6.2   #42768   +/-   ##
======================================
  Coverage       ?   64.33%           
======================================
  Files          ?     2554           
  Lines          ?   132898           
  Branches       ?    30793           
======================================
  Hits           ?    85503           
  Misses         ?    45925           
  Partials       ?     1470           
Flag Coverage Δ
hive 39.89% <0.00%> (?)
mysql 60.41% <66.66%> (?)
postgres 60.47% <66.66%> (?)
presto 39.90% <0.00%> (?)
python 62.04% <66.66%> (?)
sqlite 60.12% <66.66%> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luizotavio32
luizotavio32 marked this pull request as ready for review August 5, 2026 03:22
@dosubot dosubot Bot added authentication Related to authentication embedded labels Aug 5, 2026
@luizotavio32
luizotavio32 marked this pull request as draft August 5, 2026 03:29
@luizotavio32
luizotavio32 marked this pull request as ready for review August 5, 2026 03:29
@github-actions github-actions Bot removed the embedded label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication Related to authentication size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants