Skip to content

Update down_revision to fix migrations - #7850

Merged
graceguo-supercat merged 1 commit into
apache:masterfrom
1AB9502:migrations
Jul 11, 2019
Merged

Update down_revision to fix migrations #7850
graceguo-supercat merged 1 commit into
apache:masterfrom
1AB9502:migrations

Conversation

@1AB9502

@1AB9502 1AB9502 commented Jul 11, 2019

Copy link
Copy Markdown

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

We forgot to update down_revision in #4725, so now the migrations have 2 heads.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@1AB9502

1AB9502 commented Jul 11, 2019

Copy link
Copy Markdown
Author

Looking into why travis is failing

@graceguo-supercat

Copy link
Copy Markdown

thanks for the quick fix. will merge after ci passed.

@graceguo-supercat graceguo-supercat left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1AB9502

1AB9502 commented Jul 11, 2019

Copy link
Copy Markdown
Author

@graceguo-supercat ,

Thanks! 1 test is still failing, so I am looking into it now

@graceguo-supercat
graceguo-supercat merged commit 9eccae3 into apache:master Jul 11, 2019
@graceguo-supercat

Copy link
Copy Markdown

don't worry about unit test failing...it's false alert from cypress. i will make a new PR for this issue.

alex-mark pushed a commit to alex-mark/incubator-superset that referenced this pull request Jul 29, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants