Skip to content

[SYSTEMDS-3672] GIO Test Cases false positive #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j143 merged 1 commit into from
Feb 24, 2024
Merged

[SYSTEMDS-3672] GIO Test Cases false positive #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderCustomTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

public class FrameGenerateReaderCustomTest extends GenerateReaderFrameTest {

private final static String TEST_NAME = "FrameGenerateReaderCSVTest";
private final static String TEST_NAME = "FrameGenerateReaderCustomTest";

@Override
protected String getTestName() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/apache/sysds/test/functions/iogen/FrameGenerateReaderXMLTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

public class FrameGenerateReaderXMLTest extends GenerateReaderFrameTest {

private final static String TEST_NAME = "FrameGenerateReaderJSONTest";
private final static String TEST_NAME = "FrameGenerateReaderXMLTest";

@Override
protected String getTestName() {
Expand Down
5 changes: 1 addition & 4 deletions src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderFrameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,9 @@ protected void runGenerateReaderTest(String sampleRawFileName, String sampleFram
parallel);
FrameReader fr = gr.getReader();
fr.readFrameFromHDFS(dataFileName, sampleSchema, rows, sampleSchema.length);

// TODO Verify the frameblock contains the correct values.

}
catch(Exception exception) {
exception.printStackTrace();
throw new RuntimeException(exception);
}
finally {
rtplatform = oldPlatform;
Expand Down
19 changes: 1 addition & 18 deletions src/test/java/org/apache/sysds/test/functions/iogen/GenerateReaderMatrixTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ public abstract class GenerateReaderMatrixTest extends AutomatedTestBase {

protected final static String TEST_DIR = "functions/iogen/";
protected final static String TEST_CLASS_DIR = TEST_DIR + GenerateReaderMatrixTest.class.getSimpleName() + "/";
protected String sampleRaw;
protected double[][] sampleMatrix;

protected abstract String getTestName();

@Override
Expand All @@ -44,20 +41,6 @@ public void setUp() {
addTestConfiguration(getTestName(), new TestConfiguration(TEST_DIR, getTestName(), new String[] {"Y"}));
}

protected void generateRandomSymmetric(int size, double min, double max, double sparsity, boolean isSkew) {
sampleMatrix = getRandomMatrix(size, size, min, max, sparsity, 714);
int conf = isSkew ? -1 : 1;
for(int i = 0; i < size; i++) {
for(int j = 0; j <= i; j++) {

if(i != j)
sampleMatrix[i][j] = sampleMatrix[j][i] * conf;
else
sampleMatrix[i][j] = 0;
}
}
}

@SuppressWarnings("unused")
protected void runGenerateReaderTest(String sampleRawFileName, String sampleMatrixFileName, boolean parallel) {

Expand Down Expand Up @@ -90,7 +73,7 @@ protected void runGenerateReaderTest(String sampleRawFileName, String sampleMatr

}
catch(Exception exception) {
exception.printStackTrace();
throw new RuntimeException(exception);
}
finally {
rtplatform = oldPlatform;
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/apache/sysds/test/functions/iogen/MatrixGenerateReaderMMTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

public class MatrixGenerateReaderMMTest extends GenerateReaderMatrixTest {

private final static String TEST_NAME = "FrameGenerateReaderLibSVMTest";
private final static String TEST_NAME = "MatrixGenerateReaderMMTest";

@Override
protected String getTestName() {
Expand Down