Sparse row templates#2276
Closed
Twolvero wants to merge 14 commits into
Closed
Conversation
Contributor
|
There seem to be still some codegen errors - do you need any help @Frxms ? |
Contributor
Author
|
As far as i understood it, the Unary class was missing its ROW_VARS case. Could you run the tests again please? @mboehm7 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
============================================
- Coverage 72.94% 72.56% -0.39%
- Complexity 46070 46260 +190
============================================
Files 1479 1489 +10
Lines 172616 174458 +1842
Branches 33783 34266 +483
============================================
+ Hits 125922 126598 +676
- Misses 37202 38266 +1064
- Partials 9492 9594 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented SparseRowVectors into the Binary and Unary templates. I have also added an "S" to every result variable that is sparse to keep track of sparse intermediates.