Skip to content

[MINOR] PythonAPI: Fix for correct logging setup for debug#2295

Closed
e-strauss wants to merge 1 commit into
apache:mainfrom
e-strauss:python_apI_debug_mode
Closed

[MINOR] PythonAPI: Fix for correct logging setup for debug#2295
e-strauss wants to merge 1 commit into
apache:mainfrom
e-strauss:python_apI_debug_mode

Conversation

@e-strauss

@e-strauss e-strauss commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

I think there is a bug in the current setup of the logging in the Python SystemDS context, because the debug logging was not working on machine.

The first commit contains test if setup worked correctly, which fails.
The second commit fixes the setup.

@Baunsgaard

Copy link
Copy Markdown
Contributor

@Elias-Strauss

Okay, I took a look, and I think this is not a perfect solution; however, it works. Therefore, LGTM.

Perhaps it would be better to change the logging error to only be invoked once on the instantiation of the first SDS context. This way, we could adjust the logging level of the error without requiring workarounds like the changes and previous code in this PR.

@Baunsgaard Baunsgaard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-strauss

Copy link
Copy Markdown
Contributor Author

@Elias-Strauss

Perhaps it would be better to change the logging error to only be invoked once on the instantiation of the first SDS context. This way, we could adjust the logging level of the error without requiring workarounds like the changes and previous code in this PR.

ahh, so like a check (a boolean in the class) if the logging is initialized before. If no we clear and add the new handler.
If its initialized, we just adjust the logging levels?

@e-strauss e-strauss force-pushed the python_apI_debug_mode branch from a13985a to 21aa002 Compare July 23, 2025 12:46
@e-strauss e-strauss closed this in 455a738 Jul 23, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SystemDS PR Queue Jul 23, 2025
@e-strauss e-strauss deleted the python_apI_debug_mode branch July 23, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants