[MINOR] PythonAPI: Fix for correct logging setup for debug#2295
[MINOR] PythonAPI: Fix for correct logging setup for debug#2295e-strauss wants to merge 1 commit into
Conversation
c67f597 to
2fe0503
Compare
|
Okay, I took a look, and I think this is not a perfect solution; however, it works. Therefore, LGTM. Perhaps it would be better to change the logging error to only be invoked once on the instantiation of the first SDS context. This way, we could adjust the logging level of the error without requiring workarounds like the changes and previous code in this PR. |
ahh, so like a check (a boolean in the class) if the logging is initialized before. If no we clear and add the new handler. |
a13985a to
21aa002
Compare
I think there is a bug in the current setup of the logging in the Python SystemDS context, because the debug logging was not working on machine.
The first commit contains test if setup worked correctly, which fails.
The second commit fixes the setup.