Skip to content

Sparse row optimizer#2297

Closed
Twolvero wants to merge 79 commits into
apache:mainfrom
Twolvero:Sparse-Row-Optimizer
Closed

Sparse row optimizer#2297
Twolvero wants to merge 79 commits into
apache:mainfrom
Twolvero:Sparse-Row-Optimizer

Conversation

@Twolvero

Copy link
Copy Markdown
Contributor

This is the optimizer for the sparse row templates.

@codecov

codecov Bot commented Aug 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.03769% with 262 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.56%. Comparing base (38b73ae) to head (63aac6b).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
...ache/sysds/runtime/codegen/LibSpoofPrimitives.java 83.90% 108 Missing and 34 partials ⚠️
...g/apache/sysds/hops/codegen/cplan/CNodeBinary.java 31.57% 25 Missing and 27 partials ⚠️
...g/apache/sysds/hops/codegen/cplan/java/Binary.java 29.03% 18 Missing and 4 partials ⚠️
...org/apache/sysds/runtime/codegen/SpoofRowwise.java 50.00% 8 Missing and 4 partials ⚠️
...rg/apache/sysds/hops/codegen/cplan/CNodeUnary.java 66.66% 3 Missing and 4 partials ⚠️
...ava/org/apache/sysds/hops/codegen/cplan/CNode.java 40.00% 2 Missing and 4 partials ⚠️
...parser/ParameterizedBuiltinFunctionExpression.java 54.54% 3 Missing and 2 partials ⚠️
.../apache/sysds/hops/codegen/cplan/CNodeTernary.java 20.00% 0 Missing and 4 partials ⚠️
...rc/main/java/org/apache/sysds/hops/AggUnaryOp.java 84.21% 2 Missing and 1 partial ⚠️
...org/apache/sysds/hops/codegen/cplan/CNodeNary.java 33.33% 1 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2297      +/-   ##
============================================
- Coverage     72.94%   72.56%   -0.39%     
- Complexity    46070    46632     +562     
============================================
  Files          1479     1492      +13     
  Lines        172616   176042    +3426     
  Branches      33783    34576     +793     
============================================
+ Hits         125922   127737    +1815     
- Misses        37202    38660    +1458     
- Partials       9492     9645     +153     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mboehm7

mboehm7 commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

LGTM - thanks for this substantial contribution and the related effort @Frxms. During the merge, I rebased the 60+ commits, resolved all merge conflicts, added the missing license headers (that's why the license check was failing), resolved warnings, and left a few TODOs for future cleanups. That completes this feature and I'll also close the remaining PRs which are subsets of this one.

@mboehm7 mboehm7 closed this in b1c5d64 Aug 20, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SystemDS PR Queue Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants