Sparse row optimizer#2297
Closed
Twolvero wants to merge 79 commits into
Closed
Conversation
# Conflicts: # src/main/java/org/apache/sysds/hops/codegen/cplan/CNodeBinary.java
…enefit doesn't come from one operation being sparse, but consecutive sparse operations. Change templateRow to check the sparsity of the input in CNodeUnary constructor call
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
============================================
- Coverage 72.94% 72.56% -0.39%
- Complexity 46070 46632 +562
============================================
Files 1479 1492 +13
Lines 172616 176042 +3426
Branches 33783 34576 +793
============================================
+ Hits 125922 127737 +1815
- Misses 37202 38660 +1458
- Partials 9492 9645 +153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM - thanks for this substantial contribution and the related effort @Frxms. During the merge, I rebased the 60+ commits, resolved all merge conflicts, added the missing license headers (that's why the license check was failing), resolved warnings, and left a few TODOs for future cleanups. That completes this feature and I'll also close the remaining PRs which are subsets of this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the optimizer for the sparse row templates.