Einsum, initial PR (after rebase)#2312
Closed
HubertKrawczyk wants to merge 28 commits into
Closed
Conversation
… does matrix muls and elemwise muls with sums
…d also by refresh size method
…outermultpl. change
…degen is needed, elementwise mutliplication between matrix and vector works
… optimal; by default no codegen is used
Closed
Contributor
|
LGTM - thanks for this first version of the new einsum framework @HubertKrawczyk. I also appreciate the clean rebased PR. Overall, the code looks fine - during the merge, I only resolved a few warnings (imports, unused code, generic typing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces initial version of einsum operator to SystemDS.
Einsum operator follows structure of Numpy einsum https://numpy.org/doc/stable/reference/generated/numpy.einsum.html
For tests, R package einsum https://cran.r-project.org/web/packages/einsum/einsum.pdf is used
Implemented so far:
(M Thesis at TU Berlin "Efficient Einstein Summation in Apache SystemDS")