[SYSTEMDS-3907] Tee OOC operator#2315
Closed
j143 wants to merge 27 commits into
Closed
Conversation
* remove commented code * add java doc
Member
Author
|
Hi @mboehm7 , could you please check this once. thanks. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
=======================================
Coverage ? 72.28%
Complexity ? 46695
=======================================
Files ? 1500
Lines ? 177041
Branches ? 34790
=======================================
Hits ? 127976
Misses ? 39413
Partials ? 9652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the great patch @j143 - overall, this looks very solid. I would recommend to move the TeeOp into the existing DataOp though, and split the OOC transpose into a separate PR (which we can test and merge separately). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I tried to rewrite and add tee operator in the graph. The Tee and Transpose tests are working.
Transpose OOC is also implemented (working).
Plan
Diagram: