[SYSTEMDS-3932] CSV reader for out-of-core streams #2352
Closed
janniklinde wants to merge 3 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2352 +/- ##
============================================
+ Coverage 72.29% 72.32% +0.02%
- Complexity 46829 46880 +51
============================================
Files 1508 1509 +1
Lines 177638 177962 +324
Branches 34880 34938 +58
============================================
+ Hits 128430 128708 +278
- Misses 39511 39535 +24
- Partials 9697 9719 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM - thanks for the patch and the additional simplification @janniklinde. For now we focus on lean code and optimizing the common case in terms of data characteristics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds an out-of-core CSV reblock instruction. It supports reading single or multiple row partitioned CSV files into dense matrix blocks. Reads are currently performed by a single thread and thus performance is comparable to (slightly slower than) non-parallel dense CSV reads if all blocks per row can be held in cache. The number of maximum
blenxblenmatrix blocks that are constructed in memory simultaneously can be specified byMAX_BLOCKS_IN_CACHE.