Skip to content

THRIFT-6067: [py] Remove sys.exit() from setup.py to fix PEP 517 builds on setuptools < 69 #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jens-G merged 1 commit into from
Jun 6, 2026
Merged

THRIFT-6067: [py] Remove sys.exit() from setup.py to fix PEP 517 builds on setuptools < 69 #3584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions lib/py/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,28 +144,14 @@ def run_setup(with_binary):


try:
with_binary = True
run_setup(with_binary)
sys.exit(0)

run_setup(with_binary=True)
except BuildFailed:
print()
print('*' * 80)
print("An error occurred while trying to compile with the C extension enabled")
print("Attempting to build without the extension now")
print('*' * 80)
print()

# Retry but without the binary
try:
run_setup(False)
sys.exit(0)

except BuildFailed:
print()
print('*' * 80)
print("An error occurred while trying to compile without the C extension enabled")
print("Build failed")
print('*' * 80)
print()
sys.exit(1)
# Fall back to the pure-Python build. If this also fails, let the
# exception propagate so the build backend reports the real error.
run_setup(with_binary=False)
Loading