Skip to content

[Runtime][PackedFunc] Bring PackedFunc into TVM Object System#10032

Merged
junrushao merged 9 commits intoapache:mainfrom
cyx-6:PackedFuncObj
Feb 3, 2022
Merged

[Runtime][PackedFunc] Bring PackedFunc into TVM Object System#10032
junrushao merged 9 commits intoapache:mainfrom
cyx-6:PackedFuncObj

Conversation

@cyx-6
Copy link
Copy Markdown
Contributor

@cyx-6 cyx-6 commented Jan 23, 2022

This PR allows developers to use PackedFunc as TVM objects, which completes the last missing step of TVM runtime object system.

Comment thread include/tvm/runtime/packed_func.h Outdated
Comment thread include/tvm/runtime/packed_func.h Outdated
Comment thread include/tvm/runtime/packed_func.h Outdated
Comment thread include/tvm/runtime/packed_func.h Outdated
Comment thread include/tvm/runtime/packed_func.h Outdated
Comment thread include/tvm/runtime/packed_func.h
Comment thread include/tvm/runtime/packed_func.h Outdated
Comment thread include/tvm/runtime/packed_func.h
Comment thread include/tvm/runtime/packed_func.h Outdated
Comment thread include/tvm/runtime/packed_func.h Outdated
@junrushao
Copy link
Copy Markdown
Member

Nice PR @cyx-6! Please also fix the lint and let's get it tested in our CI!

@junrushao
Copy link
Copy Markdown
Member

RFC: apache/tvm-rfcs#51

Comment thread include/tvm/runtime/packed_func.h
Copy link
Copy Markdown
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao junrushao merged commit f929b0f into apache:main Feb 3, 2022
@junrushao
Copy link
Copy Markdown
Member

Thanks @cyx-6 for the huge effort! It's merged!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants